Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External contribution #219

Merged
merged 9 commits into from
Jan 16, 2024
Merged

External contribution #219

merged 9 commits into from
Jan 16, 2024

Conversation

mindflayer
Copy link
Owner

@mindflayer mindflayer commented Jan 16, 2024

Thanks to @ento for his amazing contribution!

ento and others added 9 commits January 16, 2024 22:30
…after SSL handshake

Python 3.11's asyncio.sslproto implementation attempts to read
from the SSL object right after completing handshake.
python/cpython@13c10bf#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ecR603
This fails like so:

>     async def read(self) -> _T:
>         if not self._buffer and not self._eof:
>             assert not self._waiter
>             self._waiter = self._loop.create_future()
>             try:
> >               await self._waiter
> E               aiohttp.client_exceptions.ClientOSError: [Errno 1] [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:2580)
>
> .devenv/state/venv/lib/python3.11/site-packages/aiohttp/streams.py:622: ClientOSError
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 98.668% (+0.7%) from 98.015%
when pulling a5af5c3 on external-pr
into 2bca049 on main.

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mindflayer mindflayer merged commit 3edce14 into main Jan 16, 2024
11 checks passed
@mindflayer mindflayer deleted the external-pr branch January 16, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants